igc: field get conversion

Browse source

[ Upstream commit a8e0c7a680 ]

Refactor the igc driver to use FIELD_GET() for mask and shift reads,
which reduces lines of code and adds clarity of intent.

This code was generated by the following coccinelle/spatch script and
then manually repaired in a later patch.

@get@
constant shift,mask;
type T;
expression a;
@@
-((T)((a) & mask) >> shift)
+FIELD_GET(mask, a)

and applied via:
spatch --sp-file field_prep.cocci --in-place --dir \
 drivers/net/ethernet/intel/

Cc: Julia Lawall <Julia.Lawall@inria.fr>
Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Stable-dep-of: bd2776e39c ("igc: return early when failing to read EECD register")
Signed-off-by: Sasha Levin <sashal@kernel.org>

...

This commit is contained in:

Jesse Brandeburg 2023-12-05 17:01:09 -08:00 • committed by Greg Kroah-Hartman

parent 0677b13dd9

commit 30254c85b8

4 changed files with 8 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/net/ethernet/intel/igc/igc_base.c

View file

5

drivers/net/ethernet/intel/igc/igc_i225.c

View file

6

drivers/net/ethernet/intel/igc/igc_main.c

View file

4

drivers/net/ethernet/intel/igc/igc_phy.c

View file