xfs: use iomap_valid method to detect stale cached iomaps

Browse source

Now that iomap supports a mechanism to validate cached iomaps for
buffered write operations, hook it up to the XFS buffered write ops
so that we can avoid data corruptions that result from stale cached
iomaps. See:

https://lore.kernel.org/linux-xfs/20220817093627.GZ3600936@dread.disaster.area/

or the ->iomap_valid() introduction commit for exact details of the
corruption vector.

The validity cookie we store in the iomap is based on the type of
iomap we return. It is expected that the iomap->flags we set in
xfs_bmbt_to_iomap() is not perturbed by the iomap core and are
returned to us in the iomap passed via the .iomap_valid() callback.
This ensures that the validity cookie is always checking the correct
inode fork sequence numbers to detect potential changes that affect
the extent cached by the iomap.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

...

This commit is contained in:

Dave Chinner 2022-11-29 09:09:17 +11:00 • committed by Dave Chinner

parent d7b6404116

commit 304a68b9c6

5 changed files with 87 additions and 27 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

fs/xfs/libxfs/xfs_bmap.c

View file

2

fs/xfs/xfs_aops.c

View file

95

fs/xfs/xfs_iomap.c

View file

5

fs/xfs/xfs_iomap.h

View file

6

fs/xfs/xfs_pnfs.c

View file