xprtrdma: Simplify RPC wake-ups on connect

Browse source

Currently, when a connection is established, rpcrdma_conn_upcall
invokes rpcrdma_conn_func and then
wake_up_all(&ep->rep_connect_wait). The former wakes waiting RPCs,
but the connect worker is not done yet, and that leads to races,
double wakes, and difficulty understanding how this logic is
supposed to work.

Instead, collect all the "connection established" logic in the
connect worker (xprt_rdma_connect_worker). A disconnect worker is
retained to handle provider upcalls safely.

Fixes: 254f91e2fa ("xprtrdma: RPC/RDMA must invoke ... ")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

...

This commit is contained in:

Chuck Lever 2018-10-01 14:26:08 -04:00 • committed by Anna Schumaker

parent 316a616e78

commit 31e62d25b5

3 changed files with 52 additions and 48 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

58

net/sunrpc/xprtrdma/transport.c

View file

42

net/sunrpc/xprtrdma/verbs.c

View file

4

net/sunrpc/xprtrdma/xprt_rdma.h

View file