net/mlx5e: Fix devlink port register sequence

Browse source

If udevd is configured to rename interfaces according to persistent
naming rules and if a network interface has phys_port_name in sysfs,
its contents will be appended to the interface name.
However, register_netdev creates device in sysfs and if
devlink_port_register is called after that, there is a timeframe in
which udevd may read an empty phys_port_name value. The consequence is
that the interface will lose this suffix and its name will not be
really persistent.

The solution is to register the port before registering a netdev.

Fixes: c6acd629ee ("net/mlx5e: Add support for devlink-port in non-representors mode")
Signed-off-by: Vladyslav Tarasiuk <vladyslavt@mellanox.com>
Reviewed-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

...

This commit is contained in:

Vladyslav Tarasiuk 2020-03-04 13:33:50 +02:00 • committed by Saeed Mahameed

parent d0645b3780

commit 31e87b39ba

3 changed files with 21 additions and 24 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

26

drivers/net/ethernet/mellanox/mlx5/core/en/devlink.c

View file

3

drivers/net/ethernet/mellanox/mlx5/core/en/devlink.h

View file

16

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

View file