KVM: selftests: Move vcpu_args_set into perf_test_util

Browse source

perf_test_util is used to set up KVM selftests where vCPUs touch a
region of memory. The guest code is implemented in perf_test_util.c (not
the calling selftests). The guest code requires a 1 parameter, the
vcpuid, which has to be set by calling vcpu_args_set(vm, vcpu_id, 1,
vcpu_id).

Today all of the selftests that use perf_test_util are making this call.
Instead, perf_test_util should just do it. This will save some code but
more importantly prevents mistakes since totally non-obvious that this
needs to be called and failing to do so results in vCPUs not accessing
the right regions of memory.

Signed-off-by: David Matlack <dmatlack@google.com>
Message-Id: <20210805172821.2622793-1-dmatlack@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

...

This commit is contained in:

David Matlack 2021-08-05 17:28:21 +00:00 • committed by Paolo Bonzini

parent 609e6202ea

commit 32bdc01988

5 changed files with 2 additions and 5 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

tools/testing/selftests/kvm/access_tracking_perf_test.c

View file

1

tools/testing/selftests/kvm/demand_paging_test.c

View file

1

tools/testing/selftests/kvm/dirty_log_perf_test.c

View file

2

tools/testing/selftests/kvm/lib/perf_test_util.c

View file

1

tools/testing/selftests/kvm/memslot_modification_stress_test.c

View file