IPoIB/cm: Fix error handling in ipoib_cm_dev_open()

Browse source

If skb allocation fails when we start the device, we call
ipoib_cm_dev_stop() even though ipoib_cm_dev_open() did not run to
completion, so we pass an invalid pointer to ib_destroy_cm_id and get
an oops.

Fix by clearing cm.id on error, and testing it in cm_dev_stop().
This fixes <https://bugs.openfabrics.org/show_bug.cgi?id=561>

Signed-off-by: Michael S. Tsirkin <mst@dev.mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

...

This commit is contained in:

Michael S. Tsirkin 2007-04-30 17:30:28 -07:00 • committed by Roland Dreier

parent 6b66b2da1e

commit 347fcfbed2

1 changed files with 6 additions and 2 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8

drivers/infiniband/ulp/ipoib/ipoib_cm.c

View file