xfs: ask the dentry cache if it knows the parent of a directory

Browse source

It's possible that the dentry cache can tell us the parent of a
directory.  Therefore, when repairing directory dot dot entries, query
the dcache as a last resort before scanning the entire filesystem.

A reviewer asks:

"How high is the chance that we actually have a valid dcache entry for a
file in a corrupted directory?"

There's a decent chance of this actually working.  Say you have a
1000-block directory foo, and block 980 gets corrupted.  Let's further
suppose that block 0 has a correct entry for ".." and "bar".  If someone
accesses /mnt/foo/bar, that will cause the dcache to create a dentry
from /mnt to /mnt/foo whose d_parent points back to /mnt.  If you then
want to rebuild the directory, XFS can obtain the parent from the dcache
without needing to wander into parent pointers or scan the filesystem to
find /mnt's connection to foo.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>

...

This commit is contained in:

Darrick J. Wong 2024-04-15 14:54:54 -07:00

parent cc22edab9e

commit 34c9382c12

5 changed files with 81 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

29

fs/xfs/scrub/dir_repair.c

View file

38

fs/xfs/scrub/findparent.c

View file

1

fs/xfs/scrub/findparent.h

View file

13

fs/xfs/scrub/parent_repair.c

View file

1

fs/xfs/scrub/trace.h

View file