drm/i915: Move DDI clock readout to encoder->get_config()

Browse source

Move the *_get_ddi_pll() stuff into the encodet->get_config() hook.
There it neatly sits next to the matching .{enable,disable}_clock()
functions.

In order to avoid excessive boilerplate I changed the behaviour
such that all platforms now do the readout via
crtc_state->port_dpll[].

ICL+ TC is still a bit special due to TBTPLL not having a functional
.get_freq(). Should probably change that by adopting the LCPLL
approach, but that would require a fairly substantial rework of the
DPLL ID handling. So leave it for later.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210224144214.24803-5-ville.syrjala@linux.intel.com
Reviewed-by: Mika Kahola <mika.kahola@intel.com>

...

This commit is contained in:

Ville Syrjälä 2021-02-24 16:42:12 +02:00

parent d0f1bfc615

commit 351221ffc5

5 changed files with 306 additions and 250 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/gpu/drm/i915/display/icl_dsi.c

View file

2

drivers/gpu/drm/i915/display/intel_crt.c

View file

321

drivers/gpu/drm/i915/display/intel_ddi.c

View file

8

drivers/gpu/drm/i915/display/intel_ddi.h

View file

219

drivers/gpu/drm/i915/display/intel_display.c

View file