Merge branch 'net-drivers-pgcnt'

Browse source

Eric Dumazet says:

====================
net: fix races accessing page->_count

This is illegal to use atomic_set(&page->_count, ...) even if we 'own'
the page. Other entities in the kernel need to use get_page_unless_zero()
to get a reference to the page before testing page properties, so we could
loose a refcount increment.

The only case it is valid is when page->_count is 0, we can use this in
__netdev_alloc_frag()

Note that I never seen crashes caused by these races, the issue was reported
by Andres Lagar-Cavilla and Hugh Dickins.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

David S. Miller 2014-10-10 15:37:36 -04:00

parent 1fadee0c36 4c450583d9

commit 35b7a1915a

5 changed files with 30 additions and 23 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

7

drivers/net/ethernet/intel/fm10k/fm10k_main.c

View file

7

drivers/net/ethernet/intel/igb/igb_main.c

View file

8

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

View file

6

drivers/net/ethernet/mellanox/mlx4/en_rx.c

View file

25

net/core/skbuff.c

View file