stmmac: fix dma api misuse

Browse source

Enabling DMA_API_DEBUG, warnings are reported at runtime
because the device driver frees DMA memory with wrong functions
and it does not call dma_mapping_error after mapping dma memory.

The first problem is fixed by of introducing a flag that helps us
keeping track which mapping technique was used, so that we can use
the right API for unmap.
This approach was inspired by the e1000 driver, which uses a similar
technique.

Signed-off-by: Andre Draszik <andre.draszik@st.com>
Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Reviewed-by: Denis Kirjanov <kda@linux-powerpc.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Giuseppe CAVALLARO 2014-08-27 11:27:00 +02:00 • committed by David S. Miller

parent 5566401f2f

commit 362b37be01

5 changed files with 79 additions and 27 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

14

drivers/net/ethernet/stmicro/stmmac/chain_mode.c

View file

2

drivers/net/ethernet/stmicro/stmmac/common.h

View file

15

drivers/net/ethernet/stmicro/stmmac/ring_mode.c

View file

7

drivers/net/ethernet/stmicro/stmmac/stmmac.h

View file

68

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

View file