RISC-V: hwprobe: Clarify cpus size parameter

Browse source

The "count" parameter associated with the 'cpus' parameter of the
hwprobe syscall is the size in bytes of 'cpus'. Naming it 'cpu_count'
may mislead users (it did me) to think it's the number of CPUs that
are or can be represented by 'cpus' instead. This is particularly
easy (IMO) to get wrong since 'cpus' is documented to be defined by
CPU_SET(3) and CPU_SET(3) also documents a CPU_COUNT() (the number
of CPUs in set) macro. CPU_SET(3) refers to the size of cpu sets
with 'setsize'. Adopt 'cpusetsize' for the hwprobe parameter and
specifically state it is in bytes in Documentation/riscv/hwprobe.rst
to clarify.

Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Link: https://lore.kernel.org/r/20231122164700.127954-7-ajones@ventanamicro.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>

...

This commit is contained in:

Andrew Jones 2023-11-22 17:47:02 +01:00 • committed by Palmer Dabbelt

parent b85ea95d08

commit 36d842d654

No known key found for this signature in database

GPG key ID: 2E1319F35FBB1889

6 changed files with 23 additions and 30 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

15

Documentation/arch/riscv/hwprobe.rst

View file

14

arch/riscv/kernel/sys_riscv.c

View file

10

arch/riscv/kernel/vdso/hwprobe.c

View file

2

tools/testing/selftests/riscv/hwprobe/hwprobe.c

View file

2

tools/testing/selftests/riscv/hwprobe/hwprobe.h

View file

10

tools/testing/selftests/riscv/vector/vstate_prctl.c

View file