NFS: Fix a deadlock with lazy umount

Browse source

We can't allow rpc callback functions like task->tk_ops->rpc_call_prepare()
and task->tk_ops->rpc_call_done() to call mntput() in any way, since
that will cause a deadlock when the call to rpc_shutdown_client() attempts
to wait on 'task' to complete.

We can avoid the above deadlock by moving calls to mntput to
task->tk_ops->rpc_release() callback, since at that time the task will be
marked as completed, and so rpc_shutdown_client won't attempt to wait on
it.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

...

This commit is contained in:

Trond Myklebust 2008-02-19 20:04:20 -05:00

parent 4b5621f6b1

commit 383ba71938

4 changed files with 23 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

fs/nfs/direct.c

View file

6

fs/nfs/inode.c

View file

7

fs/nfs/read.c

View file

13

fs/nfs/write.c

View file