drm/v3d: Fix and extend MMU error handling.

Browse source

We were setting the wrong flags to enable PTI errors, so we were
seeing reads to invalid PTEs show up as write errors.  Also, we
weren't turning on the interrupts.  The AXI IDs we were dumping
included the outstanding write number and so they looked basically
random.  And the VIO_ADDR decoding was based on the MMU VA_WIDTH for
the first platform I worked on and was wrong on others.  In short,
this was a thorough mess from early HW enabling.

Tested on V3D 4.1 and 4.2 with intentional L2T, CLE, PTB, and TLB
faults.

Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20190419001014.23579-4-eric@anholt.net
Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

...

This commit is contained in:

Eric Anholt 2019-04-18 17:10:14 -07:00

parent 1ba9d7cbc4

commit 38c2c7917a

5 changed files with 37 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/gpu/drm/v3d/v3d_drv.c

View file

2

drivers/gpu/drm/v3d/v3d_drv.h

View file

29

drivers/gpu/drm/v3d/v3d_irq.c

View file

7

drivers/gpu/drm/v3d/v3d_mmu.c

View file

3

drivers/gpu/drm/v3d/v3d_regs.h

View file