bcachefs: Fix for bad stripe pointers

Browse source

The allocator usually doesn't increment bucket gens right away on
buckets that it's about to hand out (for reasons that need to be
documented), instead deferring that to whatever extent update first
references that bucket.

But stripe pointers reference buckets without changing bucket sector
counts, meaning we could end up with a pointer in a stripe with a gen
newer than the bucket it points to.

Fix this by adding a transactional trigger for KEY_TYPE_stripe that just
writes out the keys in the alloc btree for the buckets it points to.

Also - consolidate the code that checks pointer validity.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Kent Overstreet 2020-10-19 22:36:24 -04:00 • committed by Kent Overstreet

parent 289980195f

commit 39283c712e

5 changed files with 190 additions and 104 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

fs/bcachefs/alloc_background.c

View file

3

fs/bcachefs/alloc_background.h

View file

1

fs/bcachefs/btree_types.h

View file

5

fs/bcachefs/btree_update_leaf.c

View file

315

fs/bcachefs/buckets.c

View file