Staging: batman-adv: count batman_if list queries as reference

Browse source

The return of get_batman_if_by_netdev and get_active_batman_if leaks a
pointer from the rcu protected list of interfaces. We must protect it to
prevent a too early release of the memory. Those functions must increase
the reference counter before rcu_read_unlock or it may be to late to
prevent a free.

hardif_add_interface must also increase the reference count for the
returned batman_if to make the behaviour consistent.

Reported-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

...

This commit is contained in:

Sven Eckelmann 2010-09-18 21:01:20 +02:00 • committed by Greg Kroah-Hartman

parent 47f621dddc

commit 399fb5b445

3 changed files with 56 additions and 19 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/staging/batman-adv/TODO

View file

42

drivers/staging/batman-adv/bat_sysfs.c

View file

29

drivers/staging/batman-adv/hard-interface.c

View file