nfsd: store stat times in fill_pre_wcc() instead of inode times

Browse source

The time values in stat and inode may differ for overlayfs and stat time
values are the correct ones to use. This is also consistent with the fact
that fill_post_wcc() also stores stat time values.

This means introducing a stat call that could fail, where previously we
were just copying values out of the inode.  To be conservative about
changing behavior, we fall back to copying values out of the inode in
the error case.  It might be better just to clear fh_pre_saved (though
note the BUG_ON in set_change_info).

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

...

This commit is contained in:

Amir Goldstein 2018-01-03 17:14:35 +02:00 • committed by J. Bruce Fields

parent 76c479480b

commit 39ca1bf624

3 changed files with 37 additions and 24 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

31

fs/nfsd/nfs3xdr.c

View file

2

fs/nfsd/nfs4xdr.c

View file

28

fs/nfsd/nfsfh.h

View file