bpf: Fix verifier assumptions about socket->sk

Browse source

[ Upstream commit 0db63c0b86 ]

The verifier assumes that 'sk' field in 'struct socket' is valid
and non-NULL when 'socket' pointer itself is trusted and non-NULL.
That may not be the case when socket was just created and
passed to LSM socket_accept hook.
Fix this verifier assumption and adjust tests.

Reported-by: Liam Wisehart <liamwisehart@meta.com>
Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Fixes: 6fcd486b3a ("bpf: Refactor RCU enforcement in the verifier.")
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/r/20240427002544.68803-1-alexei.starovoitov@gmail.com
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

...

This commit is contained in:

Alexei Starovoitov 2024-04-26 17:25:44 -07:00 • committed by Greg Kroah-Hartman

parent 62eb07923f

commit 39f8a29330

4 changed files with 38 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

23

kernel/bpf/verifier.c

View file

5

tools/testing/selftests/bpf/progs/bench_local_storage_create.c

View file

20

tools/testing/selftests/bpf/progs/local_storage.c

View file

8

tools/testing/selftests/bpf/progs/lsm_cgroup.c

View file