GFS2: Fix use-after-free bug on umount

Browse source

There was a use-after-free with the GFS2 super block during
umount. This patch moves almost all of the umount code from
->put_super into ->kill_sb, the only bit that cannot be moved
being the glock hash clearing which has to remain as ->put_super
due to umount ordering requirements. As a result its now obvious
that the kfree is the final operation, whereas before it was
hidden in ->put_super.

Also gfs2_jindex_free is then only referenced from a single file
so thats moved and marked static too.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

...

This commit is contained in:

Steven Whitehouse 2008-11-27 08:27:28 +00:00

parent 2e204703a1

commit 3af165ac4d

6 changed files with 94 additions and 114 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

fs/gfs2/glock.c

View file

2

fs/gfs2/glock.h

View file

98

fs/gfs2/ops_fstype.c

View file

68

fs/gfs2/ops_super.c

View file

34

fs/gfs2/super.c

View file

3

fs/gfs2/super.h

View file