nvme: move nvme_stop_keep_alive() back to original position

Browse source

Stopping keep-alive not only stops the keep-alive workqueue,
but also needs to be synchronized with I/O termination as we
must not send a keep-alive command after all I/O had been
terminated.
So to avoid any regressions move the call to stop_keep_alive()
back to its original position and ensure that keep-alive is
correctly stopped failing to setup the admin queue.

Fixes: 4733b65d82 ("nvme: start keep-alive after admin queue setup")
Suggested-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>

...

This commit is contained in:

Hannes Reinecke 2023-11-21 09:01:03 +01:00 • committed by Keith Busch

parent 11b9d0b499

commit 3af755a468

4 changed files with 11 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/nvme/host/core.c

View file

19

drivers/nvme/host/fc.c

View file

1

drivers/nvme/host/rdma.c

View file

1

drivers/nvme/host/tcp.c

View file