vfio-pci: Don't use device_lock around AER interrupt setup

Browse source

device_lock is much too prone to lockups.  For instance if we have a
pending .remove then device_lock is already held.  If userspace
attempts to modify AER signaling after that point, a deadlock occurs.
eventfd setup/teardown is already protected in vfio with the igate
mutex.  AER is not a high performance interrupt, so we can also use
the same mutex to protect signaling versus setup races.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

...

This commit is contained in:

Alex Williamson 2014-01-14 16:12:55 -07:00

parent d10999016f

commit 3be3a074cf

2 changed files with 4 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/vfio/pci/vfio_pci.c

View file

17

drivers/vfio/pci/vfio_pci_intrs.c

View file