drm/msm: Defer VMA unmap for fb unpins

Browse source

With the conversion to drm_gpuvm, we lost the lazy VMA cleanup, which
means that fb cleanup/unpin when pageflipping to new scanout buffers
immediately unmaps the scanout buffer.  This is costly (with tlbinv,
it can be 4-6ms for a 1080p scanout buffer, and more for higher
resolutions)!

To avoid this, introduce a vma_ref, which is incremented whenever
userspace has a GEM handle or dma-buf fd.  When unpinning if the
vm is the kms->vm we defer tearing down the VMA until the vma_ref
drops to zero.  If the buffer is still part of a flip-chain then
userspace will be holding some sort of reference to the BO, either
via a GEM handle and/or dma-buf fd.  So this avoids unmapping the VMA
when there is a strong possibility that it will be needed again.

Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
Tested-by: Antonino Maniscalco <antomani103@gmail.com>
Reviewed-by: Antonino Maniscalco <antomani103@gmail.com>
Patchwork: https://patchwork.freedesktop.org/patch/661538/

...

This commit is contained in:

Rob Clark 2025-06-29 13:13:24 -07:00

parent 8d4c21718c

commit 3bebfd53af

6 changed files with 123 additions and 26 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/gpu/drm/msm/msm_drv.c

View file

1

drivers/gpu/drm/msm/msm_drv.h

View file

5

drivers/gpu/drm/msm/msm_fb.c

View file

60

drivers/gpu/drm/msm/msm_gem.c

View file

28

drivers/gpu/drm/msm/msm_gem.h

View file

54

drivers/gpu/drm/msm/msm_gem_prime.c

View file