ASoC: bcm2835: Enforce full symmetry

Browse source

bcm2835's configuration registers can't be changed when a stream
is running, which means asymmetric configurations aren't supported.

Channel and rate symmetry are already enforced by constraints
but samplebits had been missed.

As hw_params doesn't check for symmetry constraints by itself
and just returns success if a stream is running this led to
situations where asymmetric configurations were seeming to
succeed but of course didn't work because the hardware wasn't
configured at all.

Fix this by adding the missing samplerate symmetry constraint.

Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Matthias Reichl 2017-11-08 21:03:32 +01:00 • committed by Mark Brown

parent 675c0ee514

commit 3d2b3c707b

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 2 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

sound/soc/bcm/bcm2835-i2s.c

View file