net: hns3: Fix for the null pointer problem occurring when initializing ae_dev failed

Browse source

When initializing ae_dev failed during loading hclge.ko, the drvdata will
be set to null. When removing hns3.ko, we get a null ae_dev. It causes the
null pointer problem.

This patch removes pci_set_drvdata from error handle of hclge_init_ae_dev
to fix the bug, since pci_set_drvdata has been called in hns3_remove.
Also, we do not need to uninit the ae_dev which is not initialized. And
it may be the one which is initialized failed.

Fixes: 46a3df9f97 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support")
Signed-off-by: Fuyun Liang <liangfuyun1@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Fuyun Liang 2018-05-15 19:20:06 +01:00 • committed by David S. Miller

parent 2312e050f4

commit 3e249d3bed

3 changed files with 9 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/net/ethernet/hisilicon/hns3/hnae3.c

View file

5

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

View file

6

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c

View file