iwlwifi: dbg: Mark ucode tlv data as const

Browse source

The ucode TLV data may be read-only and should be treated as const
pointers, but currently a few code forcibly cast to the writable
pointer unnecessarily.  This gave developers a wrong impression as if
it can be modified, resulting in crashing regressions already a couple
of times.

This patch adds the const prefix to those cast pointers, so that such
attempt can be caught more easily in future.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/20210112132449.22243-3-tiwai@suse.de
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

...

This commit is contained in:

Takashi Iwai 2021-01-12 14:24:49 +01:00 • committed by Luca Coelho

parent 410f758529

commit 403ea939ea

3 changed files with 28 additions and 26 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

50

drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c

View file

2

drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.h

View file

2

drivers/net/wireless/intel/iwlwifi/iwl-drv.c

View file