SUNRPC: Do not dereference non-socket transports in sysfs

Browse source

Do not cast the struct xprt to a sock_xprt unless we know it is a UDP or
TCP transport. Otherwise the call to lock the mutex will scribble over
whatever structure is actually there. This has been seen to cause hard
system lockups when the underlying transport was RDMA.

Fixes: b49ea673e1 ("SUNRPC: lock against ->sock changing during sysfs read")
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

...

This commit is contained in:

Trond Myklebust 2022-03-25 10:37:31 -04:00

parent 1d15d121cc

commit 421ab1be43

4 changed files with 54 additions and 31 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

include/linux/sunrpc/xprt.h

View file

1

include/linux/sunrpc/xprtsock.h

View file

55

net/sunrpc/sysfs.c

View file

26

net/sunrpc/xprtsock.c

View file