bcachefs: bch2_btree_delete_range_trans() now returns -BCH_ERR_transaction_restart_nested

Browse source

The new convention is that functions that handle transaction restarts
within an existing transaction context should return
-BCH_ERR_transaction_restart_nested when they did so, since they
invalidated the outer transaction context.

This also means bch2_btree_delete_range_trans() is changed to only call
bch2_trans_begin() after a transaction restart, not on every loop
iteration.

This is to fix a bug in fsck, in check_inode() when we truncate an inode
with BCH_INODE_I_SIZE_DIRTY set.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>

...

This commit is contained in:

Kent Overstreet 2022-08-18 13:00:26 -04:00 • committed by Kent Overstreet

parent efd0d03816

commit 42590b53fe

2 changed files with 32 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

19

fs/bcachefs/btree_update_leaf.c

View file

30

fs/bcachefs/fsck.c

View file