sched: Remove relyance on STRUCT_ALIGNMENT

Browse source

Florian reported that all of kernel/sched/ is rebuild when
CONFIG_BLK_DEV_INITRD is changed, which, while not a bug is
unexpected. This is due to us including vmlinux.lds.h.

Jakub explained that the problem is that we put the alignment
requirement on the type instead of on a variable. Type alignment is a
minimum, the compiler is free to pick any larger alignment for a
specific instance of the type (eg. the variable).

So force the type alignment on all individual variable definitions and
remove the undesired dependency on vmlinux.lds.h.

Fixes: 85c2ce9104 ("sched, vmlinux.lds: Increase STRUCT_ALIGNMENT to 64 bytes for GCC-4.9")
Reported-by: Florian Fainelli <f.fainelli@gmail.com>
Suggested-by: Jakub Jelinek <jakub@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>

...

This commit is contained in:

Peter Zijlstra 2020-10-21 15:45:33 +02:00

parent 345a957fcc

commit 43c31ac0e6

6 changed files with 24 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

kernel/sched/deadline.c

View file

4

kernel/sched/fair.c

View file

4

kernel/sched/idle.c

View file

4

kernel/sched/rt.c

View file

17

kernel/sched/sched.h

View file

3

kernel/sched/stop_task.c

View file