drm/i915: Move the engine->destroy() vfunc onto the engine

Browse source

Make the engine responsible for cleaning itself up!

This removes the i915->gt.cleanup vfunc that has been annoying the
casual reader and myself for the last several years, and helps keep a
future patch to add more cleanup tidy.

v2: Assert that engine->destroy is set after the backend starts
allocating its own state.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190501103204.18632-1-chris@chris-wilson.co.uk

...

This commit is contained in:

Chris Wilson 2019-05-01 11:32:04 +01:00

parent 09b25812db

commit 45b9c968c5

7 changed files with 77 additions and 108 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/gpu/drm/i915/gt/intel_engine.h

View file

68

drivers/gpu/drm/i915/gt/intel_engine_cs.c

View file

2

drivers/gpu/drm/i915/gt/intel_engine_types.h

View file

51

drivers/gpu/drm/i915/gt/intel_lrc.c

View file

35

drivers/gpu/drm/i915/gt/intel_ringbuffer.c

View file

6

drivers/gpu/drm/i915/i915_drv.h

View file

19

drivers/gpu/drm/i915/i915_gem.c

View file