drm/sun4i: tcon: Don't rely on encoders to enable the TCON

Browse source

So far, we've required all the TCON-connected encoders to call the TCON
enable and disable functions.

This was made this way because in the RGB/LVDS case, the TCON is the CRTC
and the encoder. However, in all the other cases (HDMI, TV, DSI, etc.), we
have another encoder down the road that needs to be programmed.

We also needed to know which channel the encoder is connected to, which is
encoder-specific.

The CRTC's enable and disable callbacks can work just fine for our use
case, and we can get the channel to use just by looking at the type of
encoder, since that is fixed. Implement those callbacks, which will
remove some of the encoder boilerplate.

Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Link: https://patchwork.freedesktop.org/patch/msgid/90b4396e19b3eca61b2ebfdae0672074b88ad74d.1508231063.git-series.maxime.ripard@free-electrons.com

...

This commit is contained in:

Maxime Ripard 2017-10-17 11:06:12 +02:00

parent 961c645cf0

commit 45e88f994a

6 changed files with 67 additions and 80 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

22

drivers/gpu/drm/sun4i/sun4i_crtc.c

View file

8

drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c

View file

14

drivers/gpu/drm/sun4i/sun4i_rgb.c

View file

99

drivers/gpu/drm/sun4i/sun4i_tcon.c

View file

10

drivers/gpu/drm/sun4i/sun4i_tcon.h

View file

6

drivers/gpu/drm/sun4i/sun4i_tv.c

View file