eeepc-laptop: simplify how the hwmon device reads values from the EC

Browse source

The hwmon device uses ec_write() to write values to the EC.  So for
consistency it should use ec_read() to read values.  The extra layers
of indirection used did not add any value.

This may mean we no longer take the ACPI global lock for such reads
(if the EC operation region requires the lock and the EC does not).
But there is no point locking each one-byte read individually, when
write operations do not use the lock at all.

Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Signed-off-by: Len Brown <len.brown@intel.com>

...

This commit is contained in:

Alan Jenkins 2009-12-03 07:45:03 +00:00 • committed by Len Brown

parent 6b188a7b21

commit 463b4e474e

1 changed files with 21 additions and 22 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

43

drivers/platform/x86/eeepc-laptop.c

View file