ceph: fix ceph_lookup_open intent usage

Browse source

We weren't properly calling lookup_instantiate_filp when setting up the
lookup intent, which could lead to file leakage on errors.  So:

 - use separate helper for the hidden snapdir translation, immediately
   following the mds request
 - use ceph_finish_lookup for the final dentry/return value dance in the
   exit path
 - lookup_instantiate_filp on success

Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
Reviewed-by: Yehuda Sadeh <yehuda@hq.newdream.net>
Signed-off-by: Sage Weil <sage@newdream.net>

...

This commit is contained in:

Sage Weil 2011-07-26 11:28:11 -07:00

parent 9bae113a08

commit 468640e32c

3 changed files with 37 additions and 19 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

31

fs/ceph/dir.c

View file

23

fs/ceph/file.c

View file

2

fs/ceph/super.h

View file