HID: bpf: actually free hdev memory after attaching a HID-BPF program

Browse source

commit 89be8aa5b0 upstream.

Turns out that I got my reference counts wrong and each successful
bus_find_device() actually calls get_device(), and we need to manually
call put_device().

Ensure each bus_find_device() gets a matching put_device() when releasing
the bpf programs and fix all the error paths.

Cc: <stable@vger.kernel.org>
Fixes: f5c27da4e3 ("HID: initial BPF implementation")
Link: https://lore.kernel.org/r/20240124-b4-hid-bpf-fixes-v2-2-052520b1e5e6@kernel.org
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Benjamin Tissoires 2024-01-24 12:26:58 +01:00 • committed by Greg Kroah-Hartman

parent 1211da213a

commit 46b08e8f1b

2 changed files with 40 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

29

drivers/hid/bpf/hid_bpf_dispatch.c

View file

20

drivers/hid/bpf/hid_bpf_jmp_table.c

View file