USB: serial: ch341: fix control-message error handling

Browse source

commit 2d5a9c72d0 upstream.

A short control transfer would currently fail to be detected, something
which could lead to stale buffer data being used as valid input.

Check for short transfers, and make sure to log any transfer errors.

Note that this also avoids leaking heap data to user space (TIOCMGET)
and the remote device (break control).

Fixes: 6ce7610478 ("USB: Driver for CH341 USB-serial adaptor")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

...

This commit is contained in:

Johan Hovold 2017-01-06 19:15:18 +01:00 • committed by Ben Hutchings

parent e8ef835595

commit 47869679f3

1 changed files with 21 additions and 11 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

32

drivers/usb/serial/ch341.c

View file