net: mvpp2: Make mvpp2_prs_hw_read a parser entry init function

Browse source

The mvpp2_prs_hw_read function uses the 'index' field of the struct
mvpp2_prs_entry to initialize the rest of the fields. This makes it
unclear from a caller's perspective, who needs to manipulate a struct
that is not entirely initialized.

This commit makes it an init function for prs_entry, by passing it the
index as a parameter. The function now zeroes the entry, and sets the
index field before doing all other init from HW.

The function is renamed 'mvpp2_prs_init_from_hw' to make that clear.

Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Maxime Chevallier 2018-03-26 15:34:22 +02:00 • committed by David S. Miller

parent 8daf1a2d7e

commit 47e0e14eb1

1 changed files with 19 additions and 29 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

48

drivers/net/ethernet/marvell/mvpp2.c

View file