mlxsw: spectrum: Avoid copying sample values and use RCU pointer direcly instead

Browse source

Currently, only the psample_group is accessed using RCU on RX path.
However, it is possible (unlikely) that other sample values get change
during RX processing. Fix this by having the port->sample struct
accessed as RCU pointer, containing all sample values including
psample_group pointer. That avoids extra alloc per-port, copying the
values and the race condition described above.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Jiri Pirko 2020-04-27 18:13:07 +03:00 • committed by David S. Miller

parent dd0fbc89d2

commit 481ff57aad

3 changed files with 14 additions and 37 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

30

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

View file

4

drivers/net/ethernet/mellanox/mlxsw/spectrum.h

View file

17

drivers/net/ethernet/mellanox/mlxsw/spectrum_matchall.c

View file