crypto: crypto4xx - use the correct LE32 format for IV and key defs

Browse source

The hardware expects that the keys, IVs (and inner/outer hashes)
are in the le32 format.

This patch changes all hardware interface declarations to use
the correct LE32 data format for each field.

In order to pass __CHECK_ENDIAN__ checks, crypto4xx_memcpy_le
has to be honest about the endianness of its parameters.
The function was split and moved to the common crypto4xx_core.h
header. This allows the compiler to generate better code if the
sizes/len is a constant (various *_IV_LEN).

Please note that the hardware isn't consistent with the endiannes
of the save_digest field in the state record struct though.
The hashes produced by GHASH and CBC (for CCM) will be in LE32.
Whereas md5 and sha{1/,256,...} do not need any conversion.

Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

...

This commit is contained in:

Christian Lamparter 2017-10-04 01:00:10 +02:00 • committed by Herbert Xu

parent 8ef8d19543

commit 4865b122d4

4 changed files with 64 additions and 56 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/crypto/amcc/crypto4xx_alg.c

View file

40

drivers/crypto/amcc/crypto4xx_core.c

View file

47

drivers/crypto/amcc/crypto4xx_core.h

View file

29

drivers/crypto/amcc/crypto4xx_sa.h

View file