[media] rc: divide by zero bugs in s_tx_carrier()

Browse source

"carrier" comes from a get_user() in ir_lirc_ioctl().  We need to test
that it's not zero before using it as a divisor.  It might have been
nice to test for this ir_lirc_ioctl() but the mceusb driver uses zero to
disable carrier modulation.
The bug in redrat3 is a little more subtle.  The ->carrier is passed to
mod_freq_to_val() which uses it as a divisor.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

...

This commit is contained in:

Dan Carpenter 2012-09-11 07:11:24 -03:00 • committed by Mauro Carvalho Chehab

parent a52eb6c02f

commit 48cafec9a9

3 changed files with 10 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/media/rc/ene_ir.c

View file

3

drivers/media/rc/nuvoton-cir.c

View file

3

drivers/media/rc/redrat3.c

View file