smb: client: fix parsing of source mount option

Browse source

Handle trailing and leading separators when parsing UNC and prefix
paths in smb3_parse_devname().  Then, store the sanitised paths in
smb3_fs_context::source.

This fixes the following cases

$ mount //srv/share// /mnt/1 -o ...
$ cat /mnt/1/d0/f0
cat: /mnt/1/d0/f0: Invalid argument

The -EINVAL was returned because the client sent SMB2_CREATE "\\d0\f0"
rather than SMB2_CREATE "\d0\f0".

$ mount //srv//share /mnt/1 -o ...
mount: Invalid argument

The -EINVAL was returned correctly although the client only realised
it after sending a couple of bad requests rather than bailing out
earlier when parsing mount options.

Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Cc: stable@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>

...

This commit is contained in:

Paulo Alcantara 2023-06-27 21:24:47 -03:00 • committed by Steve French

parent d439b29057

commit 49024ec879

5 changed files with 80 additions and 56 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

20

fs/smb/client/cifs_dfs_ref.c

View file

2

fs/smb/client/cifsproto.h

View file

38

fs/smb/client/dfs.c

View file

59

fs/smb/client/fs_context.c

View file

17

fs/smb/client/misc.c

View file