xfs: switch (back) to a per-buftarg buffer hash

Browse source

The per-AG buffer hashes were added when all buffer lookups took a
per-hash look.  Since then we've made lookups entirely lockless and
removed the need for a hash-wide lock for inserts and removals as
well.  With this there is no need to sharding the hash, so reduce the
used resources by using a per-buftarg hash for all buftargs.

Long after writing this initially, syzbot found a problem in the buffer
cache teardown order, which this happens to fix as well by doing the
entire buffer cache teardown in one places instead of splitting it
between destroying the buftarg and the perag structures.

Link: https://lore.kernel.org/linux-xfs/aLeUdemAZ5wmtZel@dread.disaster.area/
Reported-by: syzbot+0391d34e801643e2809b@syzkaller.appspotmail.com
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Tested-by: syzbot+0391d34e801643e2809b@syzkaller.appspotmail.com
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>

...

This commit is contained in:

Christoph Hellwig 2026-03-23 08:50:53 +01:00 • committed by Carlos Maiolino

parent d02ee47bbe

commit 497560b9ef

5 changed files with 18 additions and 69 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

13

fs/xfs/libxfs/xfs_ag.c

View file

2

fs/xfs/libxfs/xfs_ag.h

View file

51

fs/xfs/xfs_buf.c

View file

10

fs/xfs/xfs_buf.h

View file

11

fs/xfs/xfs_buf_mem.c

View file