alx: use fine-grained locking instead of RTNL

Browse source

In the alx driver, all locking depended on the RTNL, but
that causes issues with ipconfig ("ip=..." command line)
because that waits for the netdev to have a carrier while
holding the RTNL, but the alx workers etc. require RTNL,
so the carrier won't be set until the RTNL is dropped and
can be acquired by alx workers. This causes long delays
at boot, as reported by Nikolai Zhubr.

Really the only sensible thing to do here is to not use
the RTNL for everything, but instead have fine-grained
locking for just the driver. Do that, it's not that hard.

Reported-by: Nikolai Zhubr <zhubr.2@gmail.com>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Johannes Berg 2021-05-12 12:19:50 +02:00 • committed by David S. Miller

parent 13511704f8

commit 4a5fe57e77

3 changed files with 76 additions and 29 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/net/ethernet/atheros/alx/alx.h

View file

17

drivers/net/ethernet/atheros/alx/ethtool.c

View file

86

drivers/net/ethernet/atheros/alx/main.c

View file