bcachefs: bch2_write_inode() now checks for changing rebalance options

Browse source

Previously, BCHFS_IOC_REINHERIT_ATTRS didn't trigger rebalance scans
when changing rebalance options - it had been missed, only the xattr
interface triggered them.

Ideally they'd be done by the transactional trigger, but unpacking the
inode to get the options is too heavy to be done in the low level
trigger - the inode trigger is run on every extent update, since the
bch_inode.bi_journal_seq has to be updated for fsync.

bch2_write_inode() is a good compromise, it already unpacks and repacks
and is not run in any super-fast paths.

Additionally, creating the new rebalance entry to trigger the scan is
now done in the same transaction as the inode update that changed the
options.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Kent Overstreet 2024-10-20 20:53:53 -04:00

parent 2d21d11253

commit 4ae6bbb522

5 changed files with 32 additions and 14 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

26

fs/bcachefs/fs.c

View file

8

fs/bcachefs/inode.h

View file

4

fs/bcachefs/rebalance.c

View file

1

fs/bcachefs/rebalance.h

View file

7

fs/bcachefs/xattr.c

View file