xfs: check sb_agblocks and sb_agblklog when validating superblock

Browse source

Currently, we don't check sb_agblocks or sb_agblklog when we validate
the superblock, which means that we can fuzz garbage values into those
values and the mount succeeds.  This leads to all sorts of UBSAN
warnings in xfs/350 since we can then coerce other parts of xfs into
shifting by ridiculously large values.

Once we've validated agblocks, make sure the agcount makes sense.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>

...

This commit is contained in:

Darrick J. Wong 2018-01-16 19:04:09 -08:00

parent be78ff0e72

commit 4bb73d0147

2 changed files with 21 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

7

fs/xfs/libxfs/xfs_fs.h

View file

14

fs/xfs/libxfs/xfs_sb.c

View file