drm/amdgpu: move devcoredump generation to a worker

Browse source

Update the way drm_coredump_printer is used based on its documentation
and Xe's code: the main idea is to generate the final version in one go
and then use memcpy to return the chunks requested by the caller of
amdgpu_devcoredump_read.

The generation is moved to a separate worker thread.

This cuts the time to copy the dump from 40s to ~0s on my machine.

---
v3:
- removed adev->coredump_in_progress and instead use work as
  the synchronisation mechanism
- use kvfree instead of kfree
---

Signed-off-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

Pierre-Eric Pelloux-Prayer 2025-02-21 14:45:19 +01:00 • committed by Alex Deucher

parent 15e19d832b

commit 4bbba79a7f

4 changed files with 91 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/gpu/drm/amd/amdgpu/amdgpu.h

View file

83

drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c

View file

7

drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.h

View file

2

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

View file