wlcore: fix usage of platform_device_add_data()

Browse source

Coverity CID 986698 reports leakage of struct wlcore_platdev_data in the
probe functions of both the SPI/SDIO interfaces. The structure passed to
platform_device_add_data() is dynamically allocated and only freed in the
error paths, however, platform_device_add_data() adds a copy of the platform
specific data to the device. Move the temporary struct that is kmemdup'ed
to the stack. This issue exists since afb43e6d (wlcore: remove if_ops from
platform_data).

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

...

This commit is contained in:

Christian Engelmayer 2014-04-24 22:35:56 +02:00 • committed by John W. Linville

parent 329d6e299f

commit 4c10416236

2 changed files with 20 additions and 31 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

28

drivers/net/wireless/ti/wlcore/sdio.c

View file

23

drivers/net/wireless/ti/wlcore/spi.c

View file