nvmet: don't return "any" ip address in discovery log page

Browse source

Its perfectly valid to assign a nvmet port to listen on "any"
IP address (traddr 0.0.0.0 for ipv4 address family) for IP based
transport ports. However, we must not return this address in
discovery log entries. Instead we need to return the address
where the request was accepted on (req->port address).

Since this is nvme transport specific, introduce an optional
.disc_traddr interface that is designed to check that a
port in question is bound to "any" IP address and if so, set
the traddr from the port where the request came from.

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

...

This commit is contained in:

Sagi Grimberg 2018-01-24 20:27:10 +02:00 • committed by Jens Axboe

parent a470143fc8

commit 4c65268588

3 changed files with 47 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

30

drivers/nvme/target/discovery.c

View file

2

drivers/nvme/target/nvmet.h

View file

18

drivers/nvme/target/rdma.c

View file