ALSA: emu10k1: simplify snd_emu10k1_audigy_dsp_convert_32_to_2x16()

Browse source

Instead of spending lots of instructions on masking and transplanting
the sign bit, sidestep the issue by replacing the last bit shift with
a wrapping addition to self.

Solution stolen from kX-project, after I pondered other ideas first.

Also, the function really doesn't need to return a constant int value.

Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Link: https://lore.kernel.org/r/20230510173917.3073107-5-oswald.buddenhagen@gmx.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>

...

This commit is contained in:

Oswald Buddenhagen 2023-05-10 19:39:07 +02:00 • committed by Takashi Iwai

parent 4102ac2975

commit 4c7bfbcf75

1 changed files with 13 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

26

sound/pci/emu10k1/emufx.c

View file