drm/xe: Move GFX_MODE programming to RTP

Browse source

The write GFX_MODE to disable engine "legacy mode" and to enable MSI-X
support was unnecessarily open-coded in xe_hw_engine_enable_ring();
it's preferable to do such programming in the engine_entries[] RTP table
since gets reflected/verified in debugfs, and will also automatically
ensure that the register is properly saved/restored around engine
resets.  This also helps consolidate common logic that was duplicated
between the main driver initialization path and the dead-code execlist
initialization path.

This also allows us to drop GFX_MODE from the list of extra registers to
be added to the GuC ADS' save-restore list since all registers on the
RTP table are added automatically.

v2:
 - Actually use the xe_rtp_match_has_msix match function added.
   (Shuicheng)

Cc: Shuicheng Lin <shuicheng.lin@intel.com>
Reviewed-by: Shuicheng Lin <shuicheng.lin@intel.com>
Link: https://patch.msgid.link/20260424-engine-setup-v2-7-59cc620a25f1@intel.com
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>

...

This commit is contained in:

Matt Roper 2026-04-24 13:48:17 -07:00

parent ee9b3c6c79

commit 4c936a0a22

5 changed files with 30 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/gpu/drm/xe/xe_execlist.c

View file

1

drivers/gpu/drm/xe/xe_guc_ads.c

View file

16

drivers/gpu/drm/xe/xe_hw_engine.c

View file

8

drivers/gpu/drm/xe/xe_rtp.c

View file

12

drivers/gpu/drm/xe/xe_rtp.h

View file