bnxt_en: Don't cancel sp_task from bnxt_close_nic().

Browse source

When implementing driver reset from tx_timeout in the next patch,
bnxt_close_nic() will be called from the sp_task workqueue.  Calling
cancel_work() on sp_task will hang the workqueue.

Instead, set a new bit BNXT_STATE_IN_SP_TASK when bnxt_sp_task() is running.
bnxt_close_nic() will wait for BNXT_STATE_IN_SP_TASK to clear before
proceeding.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Michael Chan 2015-12-09 19:35:43 -05:00 • committed by David S. Miller

parent caefe526d7

commit 4cebdcec09

2 changed files with 12 additions and 2 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

13

drivers/net/ethernet/broadcom/bnxt/bnxt.c

View file

1

drivers/net/ethernet/broadcom/bnxt/bnxt.h

View file