xfs: clean up xfs_attr_node_hasname

Browse source

The calling conventions of this function are a mess -- callers /can/
provide a pointer to a pointer to a state structure, but it's not
required, and as evidenced by the last two patches, the callers that do
weren't be careful enough about how to deal with an existing da state.

Push the allocation and freeing responsibilty to the callers, which
means that callers from the xattr node state machine steps now have the
visibility to allocate or free the da state structure as they please.
As a bonus, the node remove/add paths for larp-mode replaces can reset
the da state structure instead of freeing and immediately reallocating
it.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>

...

This commit is contained in:

Darrick J. Wong 2022-05-22 15:59:34 +10:00 • committed by Dave Chinner

parent 2fe3ffcf55

commit 4d0cdd2bb8

3 changed files with 44 additions and 31 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

63

fs/xfs/libxfs/xfs_attr.c

View file

11

fs/xfs/libxfs/xfs_da_btree.c

View file

1

fs/xfs/libxfs/xfs_da_btree.h

View file