mac80211: protect AP VLAN list with local->mtx

Browse source

It was impossible to change chanctx of master AP
for AP VLANs because the copy function requires
RTNL which can't be simply taken in mac80211 code
due to possible deadlocks.

This is required for future chanctx reservation
that re-bind vifs to new chanctx. This requires
safe AP VLAN iteration without RTNL.

Now VLANs can be iterated while holding either
RTNL or local->mtx because the list is modified
while holding both of these locks.

Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

...

This commit is contained in:

Michal Kazior 2014-03-05 13:14:08 +01:00 • committed by Johannes Berg

parent b6a550156b

commit 4e141dad26

4 changed files with 14 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

net/mac80211/cfg.c

View file

2

net/mac80211/chan.c

View file

4

net/mac80211/ieee80211_i.h

View file

9

net/mac80211/iface.c

View file